comments per page increased

29 posts / 0 new
Last post
Mike Harman
Offline
Joined: 7-02-06
Dec 27 2006 23:04
comments per page increased

OK I've increased the number of comments per page from 30 to 90.

This should mean that the #new link works for a larger number of posts, and there'll be less pages per thread.

However, it also might result in longer page loading times - particularly if you're using dial-up (but then you'll have to look at less pages, so there's a trade-off even then).

If no complaints, I might increase it further to 150. If it's annoying for some people, I'll give everyone comment settings options - so you'll be able to set the number yourself, but that might make things worse as well if you play with it without knowing what you're doing so no guarantees.

Please post if you think it's better or worse. I'm also going to try to make it possible to link to individual comments again so it's easier to reference posts.

jef costello's picture
jef costello
Offline
Joined: 9-02-06
Dec 27 2006 23:07
Mike Harman wrote:
I'm also going to try to make it possible to link to individual comments again so it's easier to reference posts.

That would be great.

Quote:
Please post if you think it's better or worse.

I think 90 is going to be too much. Will there be some kind of marker to show read/unread posts? Cause if you're looking for post 58 it could be frustrating.

petey
Offline
Joined: 13-10-05
Dec 27 2006 23:13

i thought 30 was too many. but if you put in a comment settings option, then ok.

Mike Harman
Offline
Joined: 7-02-06
Dec 27 2006 23:14
jef costello wrote:
I think 90 is going to be too much. Will there be some kind of marker to show read/unread posts? Cause if you're looking for post 58 it could be frustrating.

Er, no marker no. But surely it's easy to find a post in one page than it is between three different ones, even if it's more looking on one page?

jef costello's picture
jef costello
Offline
Joined: 9-02-06
Dec 27 2006 23:41

Did you just put on a thing to say which posts were new? cause it's buggered up the formatting.
You want to find whoever asked for it and ban him wink

Mike Harman
Offline
Joined: 7-02-06
Dec 27 2006 23:44

er, sorry, it should work now.

jef costello's picture
jef costello
Offline
Joined: 9-02-06
Dec 27 2006 23:45

looking sweet now mate nice one.

Mike Harman
Offline
Joined: 7-02-06
Dec 27 2006 23:47

cool.

So now if you've not read a post, it'll say "new" next to the time information - this could be replaced with something else more obvious later but will leave for now (rkn it's in node-forum.tpl.php - should be obvious which bit).

jef costello's picture
jef costello
Offline
Joined: 9-02-06
Dec 27 2006 23:58

it says nouveau for me cause I'm a sophisticated continental type. wink

Steven.'s picture
Steven.
Offline
Joined: 27-06-06
Dec 27 2006 23:59

I thought 30 was too many as well. Having fewer makes everything seem busier as well! I reckon 20-25 is alright (it used to be 15)

if it meant jumped to first unread worked it might be worth it, but the red "new" things work pretty well...

Mike Harman
Offline
Joined: 7-02-06
Dec 28 2006 00:40
John. wrote:
I thought 30 was too many as well. Having fewer makes everything seem busier as well! I reckon 20-25 is alright (it used to be 15)

why though?

you can refer back to previous comments without having to open another tab/window for a start, I really don't like paging very much in general.

Quote:
if it meant jumped to first unread worked it might be worth it, but the red "new" things work pretty well...

How does the red "new" thing work?

Khawaga's picture
Khawaga
Offline
Joined: 7-08-06
Dec 28 2006 01:01

90 is way better. I'm on dial-up now (can't wait to get back on DSL...) and it is not that slow. Though being able to set the options would be even better.

A read/unread marker would make browsing easier as well (as someone mentioned).

Mike Harman
Offline
Joined: 7-02-06
Dec 28 2006 01:12
atlemk wrote:
90 is way better. I'm on dial-up now (can't wait to get back on DSL...) and it is not that slow.

good to hear

Quote:
Though being able to set the options would be even better.

This would be fine, except it allows you to set not only the number of comments, but how they're displayed - and we've overridden other display settings so it might break the layout if people did it. What I might do is switch it off when I'm a bit more awake, see how much problems it causes, and then just switch it off again if it's bad. Have to see what other admins think about all this as well. We might also be able to hide the other options - if we can do this then I think it's pretty definite we could do it.

Quote:
A read/unread marker would make browsing easier as well (as someone mentioned).

There's a tiny bit of "new" text next to the time of new posts now - added it in an hour ago.

We could change this to a star or something, and with a bit more work, have a black star for read and a red star for unread or something similar. A bit more work than that and it might be possible to make it a link to the comment as well.

petey
Offline
Joined: 13-10-05
Dec 28 2006 03:20
Mike Harman wrote:
John. wrote:
I thought 30 was too many as well. Having fewer makes everything seem busier as well! I reckon 20-25 is alright (it used to be 15)

why though?

because it's simply too hard to find that one post you want if you have to scroll back through a gazillion of them on a page, or even 90. but if there's a set-you-own-number function, then hey.

HOWEVER...

i too would like to see posts numbered. the lack of this was one of the first things i noticed when i got here.

jef costello's picture
jef costello
Offline
Joined: 9-02-06
Dec 28 2006 10:33

I think it is better, although it was a bit annoying looking for the individual comment I was looking for at times. Keep it like this and perhaps a 'jump to individual post' function at some point if possible.

Tojiah's picture
Tojiah
Offline
Joined: 2-10-06
Dec 28 2006 10:59

Threading looks kind of ugly, to me. It would look better with message titles, wouldn't it?

Also, why can't the "new" link simply send you to the proper message in the proper page, regardless of how many comments there are per page?

Mike Harman
Offline
Joined: 7-02-06
Dec 28 2006 11:42
tojiah wrote:
Threading looks kind of ugly, to me. It would look better with message titles, wouldn't it?

Yeah it's horrible, I switched it off again.

Quote:
Also, why can't the "new" link simply send you to the proper message in the proper page, regardless of how many comments there are per page?

It's a bug with drupal that seems to have been largely ignored for about a year or so. Because there's options for allowing people to set the style and number of comments on pages individually, a comment can be on different pages for different people on the same site, so they'd need to cover those eventualities, which they haven't, at all. It now looks like it'll be in the version after next with a bit of luck.

jef costello's picture
jef costello
Offline
Joined: 9-02-06
Jan 15 2007 16:41

comments per page is down to 30 odd again.

petey
Offline
Joined: 13-10-05
Jan 15 2007 19:43

so i noticed. excellent.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Jan 15 2007 19:51

Yeah i switched it because threads werent loading for people.

Tojiah's picture
Tojiah
Offline
Joined: 2-10-06
Jan 15 2007 20:15

But why can't I have a shiny red "new" tag on new messages unless they're on the first page? cry It's no fair!

madashell's picture
madashell
Offline
Joined: 19-06-06
Jan 23 2007 13:09
tojiah wrote:
But why can't I have a shiny red "new" tag on new messages unless they're on the first page? cry It's no fair!

Because they go once you've clicked on the thread. Which means that when you go to the next page, the posts no longer count as "new".

If you go to http://libcom.org/forums/[forumname]/[thread-title]?page=[the page you were on minus one], it should work.

For instance, just add ?page=4 to the url for the thread to go to page 5.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Jan 23 2007 13:34

Thanks MAH smile

Tojiah's picture
Tojiah
Offline
Joined: 2-10-06
Jan 23 2007 15:52
madashell wrote:
Because they go once you've clicked on the thread. Which means that when you go to the next page, the posts no longer count as "new".

If you go to http://libcom.org/forums/[forumname]/[thread-title]?page=[the page you were on minus one], it should work.

For instance, just add ?page=4 to the url for the thread to go to page 5.

Why doesn't the "new" link point there automatically? If I can calculate it, so can drupal.

Mike Harman
Offline
Joined: 7-02-06
Jan 26 2007 18:18
tojiah wrote:
Why doesn't the "new" link point there automatically? If I can calculate it, so can drupal.

2 years.
http://drupal.org/node/6162

Tojiah's picture
Tojiah
Offline
Joined: 2-10-06
Jan 26 2007 20:24

Getting closer to three years, actually. Now it's been a while since I've programmed anything, but if you're printing out a tracker listing then for every thread you should know the total number of posts (Num_Posts) and the number of new posts (Num_New_Posts), and there's a global variable that tells you the number of posts per page (Num_Posts_Per_Page), so can't you just have "new" link to:

{Thread_URL}?page={floor((Num_Posts-Num_New_Posts)/Num_Posts_Per_Page)}

?
(pardon my pseudo-code, what's drupal written in, anyway?)

That way you get the first page where there are new posts, and you're all set, right?

Mike Harman
Offline
Joined: 7-02-06
Jan 26 2007 23:04

The problem with how drupal works is that it allows for the possibility of users customising individually how many comments are displayed per page - so it could be 10 or 100 (and hence any comment could be displayed on a number of different pages). I think that's what's holding this up.

Since we don't do that, we could probably hack something together, but none of us know enough php to do this - and you're suggestion sounds alright. Also, hacks have a tendency to get broken every upgrade, so it's a lot of work to keep up with the main release every 1-2 months, especially when you've got other little fixes elsewhere to keep track of.

Tojiah's picture
Tojiah
Offline
Joined: 2-10-06
Jan 26 2007 23:15

But since when you're printing out a tracker page you're supposed to be able to retreive that number, 'cause you know which user you're doing the printing for anyways, right? (Sorry for anthropomorphising functions, it was common practise back in my undergrad years)

I don't know any PHP whatsoever, so I wouldn't know where to start. sad

Mike Harman
Offline
Joined: 7-02-06
Jan 26 2007 23:20

Yeah I think so, but I don't know any php either - only how to cut and paste it.